Re: [PATCH 2.6.27-rc1-git5 2/26] mdb: correct kprobes int3 trap
From: Stefan Richter
Date: Wed Aug 06 2008 - 04:16:02 EST
jmerkey@xxxxxxxxxxxxxxxxxxxxx wrote on 2008-08-05:
I was unaware of checkpatch.pl, but will run it later today and submit a
git6 patch for any areas not in compliance with linux coding standards.
I guess you got complaints from scripts/checkpatch.pl for at least 3/4
of all lines by now. Some or many of the complaints will probably look
silly. Have a look at Documentation/CodingStyle then because it gives
context for many of the complaints. It also gives some rules of thumb
for things which checkpatch.pl cannot check, e.g. legibility of global
names.
From what I saw, there are _many_ whitespace "deviations" in your code
(which perhaps scripts/Lindent can help to adjust), upper case vs. lower
case in names, and occasional functions which are deeper nested than
probably necessary, as already mentioned.
--
Stefan Richter
-=====-==--- =--- --==-
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/