Re: [PATCH 00/33] dyn_array and nr_irqs support v4

From: Eric W. Biederman
Date: Wed Aug 06 2008 - 16:43:27 EST


"Yinghai Lu" <yhlu.kernel@xxxxxxxxx> writes:

>>>
>>> - Introduce get_irq_desc and the functions or function modifications
>>> that pass a struct irq_desc * into the genirq code.
>>>
>>> Although I absolutely hate the name get_irq_desc as it implies we are
>>> reference counting something and need a corresponding put_irq_desc.
>>> Since the lifetime rules don't require that. Please just call the
>>> function irq_desc().
>>
>> will check that.
>>
> how about get_irq_desc_without_new()?
>
> irq_desc_without_new()

Possibly irq_desc_with_new() or even create_irq_desc in the one or two code paths that care.
Everywhere else can reasonably assume that the irq_desc entries have either been setup, or that
the irq number is invalid.

Eric

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/