Re: [PATCH]: radeonfb: Fix copyarea for R300 and later.

From: Benjamin Herrenschmidt
Date: Wed Aug 06 2008 - 18:09:22 EST


On Wed, 2008-08-06 at 14:19 -0700, David Miller wrote:
> From: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> Date: Wed, 6 Aug 2008 08:43:29 -0700
>
> > On Wed, 06 Aug 2008 00:35:36 -0700 (PDT) David Miller <davem@xxxxxxxxxxxxx> wrote:
> >
> > > [ Andrew/Ben, this fixes the bootup hang we were talking about
> > > the other day. ]
> > >
> > > radeonfb: Fix copyarea for R300 and later.
> > >
> > > For current chips we need to make sure the DSTCACHE_CTLSTAT and
> > > WAIT_UNTIL registers are properly setup. If not, a sequence of
> > > copyarea operations can result in the 2D raster processor
> > > hanging.
> >
> > Neato. This can be backported to -stable without also backporting your
> > recent radeon-misc-corrections.patch, I assume?
>
> Yes, it can.
>
> I discussed the patch with Ben earlier and he wants to add the
> same register writes to the solidfill code as well.

That and the flush code for when we're about to manually hit the fb.

I'll send a patch later today.

Ben.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/