Re: [patch] PCI: check the return value ofdevice_create_bin_file() in pci_create_bus()

[Simon Horman]

On Thu, Aug 07, 2008 at 10:30:26AM +1000, Michael Ellerman wrote:
> On Thu, 2008-08-07 at 09:30 +1000, Simon Horman wrote:
> > Check the return value of device_create_bin_file in pci_create_bus and
> > unwind if necessary. Don't propagate error to caller, as failure to create
> > these files shouldn't prevent PCI from being initialised.
> > 
> > Cc: Sven Wegener <sven.wegener@xxxxxxxxxxx>
> > Cc: Michael Ellerman <michael@xxxxxxxxxxxxxx>
> > Cc: Matthew Wilcox <matthew@xxxxxx>
> > Signed-off-by: Simon Horman <horms@xxxxxxxxxxxx>
> 
> I hate to prolong the pain, but wasn't the plan to print a big fat
> warning so that it's clear the system is not 100% happy.

Sorry, I fogot about that bit.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/