Re: [PATCH]Fix broken VMI in 2.6.27-rc..

From: H. Peter Anvin
Date: Fri Aug 08 2008 - 12:18:11 EST


Jeremy Fitzhardinge wrote:

No, but it's hardly vast effort, either.

Thinking about it, the fixmap really has to be as high as possible. If it were any lower, then it would either truncate the 1:1 mapping, or shadow some physical memory.


The proposal was to put it *before* the 1:1 mapping:

FIX_HOLE would start at TASK_SIZE
PAGE_OFFSET would shift to TASK_SIZE + PMD_PAGE_SIZE

All the remaining offsets remain as-is.

It's slightly less efficient than the current version, since we can't share the PDE page for the fixmap with the final vmalloc map, but not terribly so.

-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/