Re: [PATCHv3] leds-pca955x: Add proper error handling and fixbogus memory handling

From: Nate Case
Date: Fri Aug 08 2008 - 12:50:27 EST


On Fri, 2008-08-08 at 09:27 +0200, Sven Wegener wrote:
> Here's a slightly updated patch, with some changes I had forgotten.
> Shouldn't change the logic at all.
>
> - Another 32 -> sizeof() conversion
> - Move the unregister code to where we also free the memory on failure
>
> And one more
>
> - cancel_work_sync() when unregistering on failure

This looks good to me. I won't be able to test it until Monday though.

--
Nate Case <ncase@xxxxxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/