Re: [PATCH] printk: robustify printk

[Andrew Morton]

On Fri, 08 Aug 2008 22:37:39 +0200
Peter Zijlstra <a.p.zijlstra@xxxxxxxxx> wrote:

> On Fri, 2008-08-08 at 13:32 -0700, Paul E. McKenney wrote:
> 
> > How about if I instead add comments warning people not to put printk()
> > in the relevant RCU-implementation code?  That way I can be not only lazy,
> > but cowardly as well!  ;-)
> 
> Well, it does spoil the party a little, we are now trading one deadlock
> for another :-/
> 

Yup.  We could just as easily put those comments into the scheduler
wakeup code.

Why are we fixing this, btw?  The problem has been there forever and
people who hack the wakeup code could/should know about it anyway.  All
they need to do is to disable klogd during development.  Did the
problem recently become worse for some reason?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/