Re: [PATCH] PNP: make the resource type an unsigned long

[Rene Herman]

On 08-08-08 23:55, H. Peter Anvin wrote:

> > Andrew earlier commented that pci_resourec_flags() returns an unsigned 
> > long. Had this hanging around a local branch. Useful?
>
> -int pnp_resource_type(struct resource *res)
> +unsigned long pnp_resource_type(struct resource *res)
>  {
>      return res->flags & (IORESOURCE_IO  | IORESOURCE_MEM |
>                   IORESOURCE_IRQ | IORESOURCE_DMA);
>  }
>
> Seems a bit pointless ... either one of those flags is >= 32 bits, in 
> which case we need u64, or it's not, in which case there is no reason to 
> burden the output with bits we don't need.

Yes, it's a not a functional patch -- only a type-consistency one. Right 
now we're mixing ints (signed ones even) and unsigned longs and while in 
this case that's not a functional problem it's messy and inconsistent.

I agree (as Andrew said earlier as well) that the struct resource flags 
member should probably just be a u32 but it's not. Changing that would 
be a bigger change than just a simple conistency thing.

Rene.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/