Re: [PATCH 08/42] introduce nr_irqs

From: Eric W. Biederman
Date: Sat Aug 09 2008 - 02:13:37 EST


"Yinghai Lu" <yhlu.kernel@xxxxxxxxx> writes:

> On Fri, Aug 8, 2008 at 6:00 PM, Eric W. Biederman <ebiederm@xxxxxxxxxxxx> wrote:
>> Yinghai Lu <yhlu.kernel@xxxxxxxxx> writes:
>>
>>> and at this point it is equal NR_IRQS
>>
>> This patch is ok, but this approach is fundamentally broken.
>> Only 19 architectures use GENERIC_HARDIRQS
>>
>> The only required interface is interrupt.h not irq.h
>>
>> So you may not replace NR_IRQS with nr_irqs in anything other
>> then genirq code and some architecture code.
>>
>> Doing so will break the build on several architectures.
>
> some platforms will not use include/linux/irq.h and kernel/irq/handle.c ?

Yes. interrupt.h is the common infrastructure.

Eric

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/