Re: [PATCH 08/42] introduce nr_irqs

[Yinghai Lu]

On Sat, Aug 9, 2008 at 9:02 AM, Eric W. Biederman <ebiederm@xxxxxxxxxxxx> wrote:
> "Yinghai Lu" <yhlu.kernel@xxxxxxxxx> writes:
>
>>> Also, what's the point, if it's just a renaming?
>>
>> that is the start point.
>> nr_irqs is variable, and will be probed later. and use that number to
>> init dyn_alloc.
>
> YH.
>
> In my conception the code in kernel/irq.c that today does:
>
> struct irq_desc *desc;
> if (irq >= NR_IRQS)
>   return -EINVAL;
> desc = irq_desc + irq;
>
> Should become:
>
> struct irq_desc *desc;
> desc = irq_desc(irq);
> if (!desc)
>   return -EINVAL;
>

OK.

also want to introduce dummy
struct irq_desc
{
   unsigned int irq;
};

in linux/interrupt.h if GENERIC_HARDIRQS is not defined.
so could have same interface
irq_desc()
and
for_each_irq_desc(irq, desc)

YH
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/