Re: Query: should 'Marvell SATA support' depend on PCI?

[Frans Pop]

Grant Coady wrote:
> I was reworking the ATA driver menu patch to shrink it (merge 'depends
> on' lines) and noticed that the:
> 
> config SATA_MV
>         tristate "Marvell SATA support (HIGHLY EXPERIMENTAL)"
>         depends on EXPERIMENTAL
>         help
>           This option enables support for the Marvell Serial ATA family.
>           Currently supports 88SX[56]0[48][01] chips.
> 
> doesn't have 'depends on PCI && EXPERIMENTAL' like other drivers around
> it, this is okay or should it also depend on PCI?

AFAICT it should not as it can also be implemented as a platform device.

I have SATA_MV on a QNAP TS-109 NAS dervice (arm) and lspci on that gives me:
$ lspci
00:00.0 Memory controller: Marvell Technology Group Ltd. Device 5182 (rev 02)
01:00.0 Memory controller: Marvell Technology Group Ltd. Device 5182 (rev 02)

So the disk controller is not on the PCI bus.
And in /sys/ I see sata_mv listed under devices/platform/.


Cheers,
FJP
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/