Re: [PATCH] ide: remove M68K_IDE_SWAPW define from <asm-m68k/ide.h>

From: Geert Uytterhoeven
Date: Sun Aug 10 2008 - 14:16:24 EST


On Sun, 10 Aug 2008, Bartlomiej Zolnierkiewicz wrote:
> Since we solved this by overriding default ->{in,out}put_data
> methods in {q40,falcon}ide M68K_IDE_SWAP define can go away.
>
> Cc: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> Cc: Roman Zippel <zippel@xxxxxxxxxxxxxx>
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@xxxxxxxxx>

Acked-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>

> ---
> include/asm-m68k/ide.h | 9 ---------
> 1 file changed, 9 deletions(-)
>
> Index: b/include/asm-m68k/ide.h
> ===================================================================
> --- a/include/asm-m68k/ide.h
> +++ b/include/asm-m68k/ide.h
> @@ -92,15 +92,6 @@
> #define outsw_swapw(port, addr, n) raw_outsw_swapw((u16 *)port, addr, n)
> #endif
>
> -
> -/* Q40 and Atari have byteswapped IDE busses and since many interesting
> - * values in the identification string are text, chars and words they
> - * happened to be almost correct without swapping.. However *_capacity
> - * is needed for drives over 8 GB. RZ */
> -#if defined(CONFIG_Q40) || defined(CONFIG_ATARI)
> -#define M68K_IDE_SWAPW (MACH_IS_Q40 || MACH_IS_ATARI)
> -#endif
> -
> #ifdef CONFIG_BLK_DEV_FALCON_IDE
> #define IDE_ARCH_LOCK

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/