[PATCH] V4L1: make PMS not autoprobe when builtin.

From: Rene Herman
Date: Sat Aug 09 2008 - 14:39:19 EST


The old Mediavision Pro Movie Studio legacy ISA V4L1 driver was
found to hang the boot during Ingo Molnar's testing of randconfig
kernels. Have it require a "pms.enable=1" kernel parameter to
enable the driver when builtin which avoids such problems.

This is a deprecated and, very likely, unused driver. Nothing
changes modular moreover.

Signed-off-by: Rene Herman <rene.herman@xxxxxxxxx>
---
drivers/media/video/pms.c | 12 ++++++++++++
1 files changed, 12 insertions(+), 0 deletions(-)

diff --git a/drivers/media/video/pms.c b/drivers/media/video/pms.c
index 00425d7..ede522a 100644
--- a/drivers/media/video/pms.c
+++ b/drivers/media/video/pms.c
@@ -1019,10 +1019,22 @@ static int init_mediavision(void)
* Initialization and module stuff
*/

+#ifndef MODULE
+static int enable;
+module_param(enable, int, 0);
+#endif
+
static int __init init_pms_cards(void)
{
printk(KERN_INFO "Mediavision Pro Movie Studio driver 0.02\n");

+#ifndef MODULE
+ if (!enable) {
+ printk(KERN_INFO "Not enabled\n");
+ return -ENODEV;
+ }
+#endif
+
data_port = io_port +1;

if(init_mediavision())
--
1.5.5


--------------060403080504020009040702--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/