RE: [PATCH 1/13 v2] viafb: viafb.modes, viafb.txt

From: Geert Uytterhoeven
Date: Mon Aug 11 2008 - 08:14:56 EST


Hi Joseph,

On Mon, 11 Aug 2008, JosephChan@xxxxxxxxxx wrote:
> > Please send an incremental patch.
> Do you mean that I can send a signle patch for fixing this issue. (v2 -> v3)

Yes.

> And the subject of this mail should be " [PATCH 1/13 v3] viafb: viafb.modes, viafb.txt"

Please also add `fix for' to the subject, so Andrew, sees its
incremental.

> -----Original Message-----
> From: geert@xxxxxxxxxxxxxx [mailto:geert@xxxxxxxxxxxxxx]
> Sent: Friday, August 08, 2008 11:25 PM
> To: Joseph Chan
> Cc: linux-fbdev-devel@xxxxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; akpm@xxxxxxxxxxxxxxxxxxxx
> Subject: RE: [PATCH 1/13 v2] viafb: viafb.modes, viafb.txt
>
> On Fri, 8 Aug 2008, JosephChan@xxxxxxxxxx wrote:
> > It should be my carelessness. The check has been added in viafbdev.c already.
>
> OK.
>
> > Do I need to re-send the patch for the documentation? Thanks for your reminding.
>
> Please send an incremental patch. Andrew is good in folding ;-)
>
> > On Fri, 8 Aug 2008, JosephChan@xxxxxxxxxx wrote:
> > > + 4. VX800 2D accelerator hasn't been supported in this driver yet. When
> > > + using driver on VX800, one should add parameter "viafb_accel=0" to
> > > + disable 2D accelerator.
> >
> > Can't the driver detect this automatically, and disable the 2D
> > accelerator when running on a VX800?

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/