Re: [PATCH] x86: Remove EXPERIMENTAL restriction fromCONFIG_HOTPLUG_CPU

[Ingo Molnar]

* Dimitri Sivanich <sivanich@xxxxxxx> wrote:

> This removes the EXPERIMENTAL restriction from CONFIG_HOTPLUG_CPU on 
> the x86 architecture.
>
> One question, should we default to 'Y'?

CONFIG_SUSPECT will select it anyway, and when suspend is disabled in 
all likelyhood it's an UP system that does not need any hotplug CPU 
support. So we dont want to enable it by default.

>  config HOTPLUG_CPU
> -	bool "Support for suspend on SMP and hot-pluggable CPUs (EXPERIMENTAL)"
> -	depends on SMP && HOTPLUG && EXPERIMENTAL && !X86_VOYAGER
> +	bool "Support for suspend on SMP and hot-pluggable CPUs"
> +	depends on SMP && HOTPLUG && !X86_VOYAGER
>  	---help---
> -	  Say Y here to experiment with turning CPUs off and on, and to
> -	  enable suspend on SMP systems. CPUs can be controlled through
> +	  Say Y here to allow turning CPUs off and on, and to enable
> +	  suspend on SMP systems. CPUs can be controlled through
>  	  /sys/devices/system/cpu.
>  	  Say N if you want to disable CPU hotplug and don't need to
>  	  suspend.

actually, the original text was incorrect/outdated, as HOTPLUG_CPU was 
already selected outside of EXPERIMENTAL, by PM_SLEEP_SMP.

So for all practical purposes HOTPLUG_CPU was already enabled in the 
Linux distro space by the side-effect of SUSPEND+PM_SLEEP enabling.

Where this change might matter is when CONFIG_PM is disabled 
intentionally on SMP - which is rather rare.

So i've clarified the text as per the commit below - is this fine with 
you?

	Ingo

------------------>