Re: [PATCH] x86: kill arch/x86/kernel/mpparse.c debugging printk.

From: Ingo Molnar
Date: Mon Aug 11 2008 - 13:42:23 EST



* Rene Herman <rene.herman@xxxxxxxxxxxx> wrote:

> On 11-08-08 18:45, Cyrill Gorcunov wrote:
>
>> | From: Rene Herman <rene.herman@xxxxxxxxx>
>> | Date: Mon, 11 Aug 2008 17:35:41 +0200
>> | Subject: [PATCH] x86: make "apic" an early_param() on 32-bit
>
> [ ... ]
>
>> you turned it into early_param so now it's NULL injecting vulnerabled.
>> Could you please add checking for NULL str param?
>
> Ah, I was unaware of that difference, thank you. Ingo, can you replace
> the previous incarnation with this one?

sure - but some other commits were queued already so i've applied the
delta fix below.

Ingo

-------------->