Re: Kernel oops with 2.6.26, padlock and ipsec: probably problemwith fpu state changes

[Ingo Molnar]

* Suresh Siddha <suresh.b.siddha@xxxxxxxxx> wrote:

> Reported-and-bisected-by: Wolfgang Walter <wolfgang.walter@xxxxxxx>
> Signed-off-by: Suresh Siddha <suresh.b.siddha@xxxxxxxxx>

no fundamental objection to the x86 bits.

shouldnt this:

+       if (!in_interrupt())
+               return 0;

just be eliminated and the cr0/TS save/restore be made unconditional?  
irq-assymetric APIs are not nice in general.

Reading/setting cr0 isnt _that_ slow. (or if it is, by how much does it 
slow things down, exactly?)

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/