Re: [PATCH] ftrace: printk formatting infrastructure fix 2

[Steven Rostedt]

On Mon, 11 Aug 2008, Andrew Morton wrote:

> On Fri, 08 Aug 2008 12:47:52 +0200
> Johannes Weiner <hannes@xxxxxxxxxxxx> wrote:

> My attempts to generate a suitable config were not happy ones.  Feast
> your eyes upon this monstrosity:
> 
> Symbol: TRACING [=y]
> Selects: DEBUG_FS && STACKTRACE
> Selected by: FTRACE && HAVE_FTRACE || IRQSOFF_TRACER && TRACE_IRQFLAGS_SUPPORT && GENERIC_TIME && HAVE_FTRACE || PREEMPT_TRACER && GENERIC_TIME && PREEMPT && HAVE_FTRACE || SYSPROF_TRACER && X86 || SCHED_TRACER && HAVE_FTRACE || CONTEXT_SWITCH_TRACER && HAVE_FTRACE || MMIOTRACE && DEBUG_KERNEL && PCI
> 

This isn't as bad as it looks.

Yes tracing selects DEBUG_FS and STACKTRACE, but the TRACING is required 
to transcend into the kernel/trace directory. That is where the other 
tracers live, and some tracers require other options to be set.

ie. FTRACE requires HAVE_FTRACE, PREEMPT_TRACER requires PREEMPT, etc.

I don't really see a problem with those config dependencies.

-- Steve



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/