Re: [ipw3945-devel] [PATCH 1/1] iwlwifi: fix printk newlines

[Zhu Yi]

On Tue, 2008-08-12 at 02:55 +0200, Marcel Holtmann wrote:
> >       s = iwl4965_get_sub_band(priv, channel);
> >       if (s >= EEPROM_TX_POWER_BANDS) {
> > -             IWL_ERROR("Tx Power can not find channel %d ",
> channel);
> > +             IWL_ERROR("Tx Power can not find channel %d\n",
> channel);
> >               return -1;
> >       }
> 
> can we not just fix IWL_ERROR to always append the newline?

We should give the users more control to the style I think.

Thanks,
-yi

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/