Re: [PATCH] ISDN: make ICN not auto-grab port 0x320

From: Adrian Bunk
Date: Tue Aug 12 2008 - 09:10:23 EST


On Mon, Aug 11, 2008 at 10:30:43PM -0700, Andrew Morton wrote:
> On Tue, 12 Aug 2008 07:02:10 +0200 Rene Herman <rene.herman@xxxxxxxxxxxx> wrote:
>
> > On 12-08-08 01:48, Andrew Morton wrote:
> >
> > > otoh it's a bit sad to break allyesconfig kernels - there is
> > > regression-testing value in being able to run such kernels.
> > >
> > > I wonder if we can add a new boot option `allyesconfig-test' or
> > > something like that, and then, within the offending drivers, test that
> > > flag and take suitable avoiding action.
> > >
> > > Or we could do it at compile-time - define
> > > CONFIG_ALLYESCONFIG_TESTING in some fashion.
> >
> > Yes, latter I'd feel with the thing most against it that there aren't
> > actually many that need it.
>
> I think the boot option is the way, if at all.
>
> Because the config option isn't very usable. What's to stop someone
> from doing `make allyesconfig' and then menually editing the .config so
> it's no longer truly an allyesconfig .config?
>
> otoh, if is't purely a manual setting rather than some automagic thing
> then it might be workable. CONFIG_INGO :)

Write the required settings into a file and use KCONFIG_ALLCONFIG.

Our kconfig files are already complicated enough, and needlessly adding
more complexity only increases the problems (which would in turn result
in this Hungarian guy spreading his kconfig FUD even more often).

Tomorrow someone might want to boot an allyesconfig kernel on an old
Pentium-MMX, and the CONFIG_M686=y allyesconfig gives might break his
boot - another special case in kconfig for an even more exotic use case?

Everyone doing randconfig builds knows that CONFIG_STANDALONE=n is not a
good idea, and similarly someone trying to boot allyesconfig kernels
might need a list of options he mustn't enable.

After all, we are not talking about stuff for normal users.

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/