Re: [PATCH] cpuset: Rework sched domains and CPU hotplug handling (take 4)

[Rakib Mullick]

On 8/12/08, Rakib Mullick <rakib.mullick@xxxxxxxxx> wrote:
> On 8/12/08, Max Krasnyansky <maxk@xxxxxxxxxxxx> wrote:
>
> > Rakib Mullick wrote:
>  >  > One more thing Max, while you are allocating memory for "dattr"  I
>  >  > think it  needs to check that it is successful or not . I've shown it
>  >  > on one of my previous patch on 7th Aug.
>  >
>  >
>  > I think you missed this part of the patch
>  >
>  >
>  >  > +     /*
>  >  > +      * The rest of the code, including the scheduler, can deal with
>  >  > +      * dattr==NULL case. No need to abort if alloc fails.
>  >  > +      */
>  >  >       dattr = kmalloc(ndoms * sizeof(struct sched_domain_attr), GFP_KERNEL);
>  >
>  >
>  > I replied to your patch saying that we do not need to check it. And Paul
>  >  suggested to add a comment to explain why.
>
Ok, this is the second place. But, what about the first place ( I
 mean in line 614).
>  >
>  >
>  >  Max
>  >
>  >
>  >
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/