Re: Setup code crashes my old 486 box

From: Ingo Molnar
Date: Wed Aug 13 2008 - 06:00:41 EST



* Joerg Roedel <joro@xxxxxxxxxx> wrote:

> On Tue, Aug 12, 2008 at 03:57:31PM -0700, H. Peter Anvin wrote:
> > Right in concept, but I dislike the implementation (duplication of the
> > CPU detect code we already have). Could you try this patch and see if
> > it works for you?
>
> Cool, with a small modification to fix a build error with it the
> resulting kernel boots my machine. Thanks.
> Would be cool to have this patch one merged soon :-)
> Attached is your patch with my little build fix. It redefines a values
> already defines in cpufeatures.h but I can't include that file in the
> boot code so I simply redeclared it. Maybe there is a cleaner solution
> for this.

thanks, i've commited the fix below to tip/x86/urgent - it should show
up in v2.6.27-rc4 and it might even be backportable to -stable. I've
added your Signed-off-by - is that ok with you?

Ingo

------------->