Re: [PATCH] Intel Management Engine Interface

[Marcin Obara]

2008/8/13 Greg KH <greg@xxxxxxxxx>:
>> GET_VERSION is called frequently
>
> Why?  Shouldn't it only be called once?
Once per connection. But you can have many clients connecting.

>> With ioctl - only one file handle is used, and userspace client logic
>> is simpler.
>
> But the kernel is messier and we are trying to not add any more ioctls
> to it.  Especially for trivial things like the version number of the
> hardware device.
It's rather protocol version (=running software version) supported by
hardware device.
Hmmm, I just didn't know that there is something wrong with ioctls.

>> Normal flow looks like:
>>
>> open
>> ioctl(GET_VERSION)
>
> Great, do an additional open/read/close here for the version, I think
> you will find it pretty trivial to do :)
Right, it's trivial.... but will make userspace source code messier and bigger.

Btw. I know we have powerful CPUs... but small wasting resources is
still wasting resources... so we still need new CPUs :-).

Regards
Marcin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/