Re: [Bugme-new] [Bug 11323] New: /proc/diskstats does not containall disk devices

[Greg KH]

On Wed, Aug 13, 2008 at 01:01:58PM -0700, Andrew Morton wrote:
> > Problem Description: /proc/diskstats does not contain all the block devices it
> > should. /sys/block has all the devices, but /proc/diskstats does not.
> > 
> > Steps to reproduce: boot a system with >9 (10?) disk devices (24 block
> > devices?)
> 
> The below would be a prime suspect.
> 
> Unfortunately a simple revert results in an uncompilable kernel.
> 
> 
> (It drives me up the wall and across the ceiling how the patch has a
> commit "date" of three months prior to the 2.6.26 release, however it
> wasn't present in 2.6.26.  What a dumb feature.  How do I make it stop
> doing this?  gitk kind of gets it right, but isn't useful across DSL)

$ git show --pretty=fuller 27f302519148f311307637d4c9a6d0fd87d07e4c

commit 27f302519148f311307637d4c9a6d0fd87d07e4c
Author:     Greg Kroah-Hartman <gregkh@xxxxxxx>
AuthorDate: Thu May 22 17:21:08 2008 -0400
Commit:     Greg Kroah-Hartman <gregkh@xxxxxxx>
CommitDate: Mon Jul 21 21:54:49 2008 -0700

There is a commit date, and the date the patch was written.  Both are
preserved in git.

And even if it was committed to a branch before 2.6.26 was released, and
then pulled in, that's fine, it's distributed development :)

$ git describe --contains 27f302519148f311307637d4c9a6d0fd87d07e4c
v2.6.27-rc1~866^2~40

showing it first showed up on 2.6.27-rc1.

Anyway, I don't have any systems with such a large number of devices to
test with.  Running git-bisect should narrow the problem down, you can't
just revert this patch as later-on patches relied on it, as you found
out...

Also, what is the output of these files, what exactly is missing?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/