Re: [PATCH] Fix the race between walk_tg_tree andsched_create_group

From: Ingo Molnar
Date: Thu Aug 14 2008 - 04:46:36 EST



* Peter Zijlstra <a.p.zijlstra@xxxxxxxxx> wrote:

> On Wed, 2030-08-14 at 15:56 +0800, Zhang, Yanmin wrote:
> > With 2.6.27-rc3, I hit a kernel panic when running volanoMark on my
> > new x86_64 machine. I also hit it with other 2.6.27-rc kernels.
> > See below log.
> >
> > Basically, function walk_tg_tree and sched_create_group have a race between
> > accessing and initiating tg->children. Below patch fixes it by moving
> > tg->children initiation to the front of linking tg->siblings to parent->children.
> >
> > Signed-off-by: Zhang Yanmin <yanmin_zhang@xxxxxxxxxxxxxxx>
>
> Nice catch
>
> Acked-by: Peter Zijlstra <a.p.zijlstra@xxxxxxxxx>

applied to tip/sched/urgent - thanks.

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/