Re: [PATCH](retry 3) invalidate caches before going into suspend

[Ingo Molnar]

* Mark Langsdorf <mark.langsdorf@xxxxxxx> wrote:

> + * Systems without cache can just go into halt.
> + */
> +static void wbinvd_halt(void) {

please put this into a unified include file, and as an inline - there's 
just a single callsite. That avoids duplication and also removes a 
function.

Also, please run the patch through scripts/checkpatch, it would have 
suggested to change this:

> +static void wbinvd_halt(void) {

to:

> +static void wbinvd_halt(void)
> +{

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/