Re: 2.6.27-rc1: critical thermal shutdown on thinkpad x60 (bisected)

[Milan Broz]

(adding cc: stable, the bug is also in 2.6.26.2)

Andi Kleen wrote:

> On Tue, Aug 12, 2008 at 08:30:04PM +0200, Dominik Brodowski wrote:
>   
>> Hi,
>>
>> On Tue, Aug 12, 2008 at 05:48:27PM +0200, Milan Broz wrote:
>>     
>>> -static unsigned int ignore_ppc = -1;
>>> +static int ignore_ppc = -1;
>>>  module_param(ignore_ppc, uint, 0644);
>>>       
>> 			    ^^^^
>> follow-up change?
>>     
yep, thanks.
I am running my x60s with this patch now:

--

Fix signed parameter in ACPI frequency notifier.

  static unsigned int ignore_ppc = -1;
...
       if (event == CPUFREQ_START && ignore_ppc <= 0) {
               ignore_ppc = 0;
...

Signed-off-by: Milan Broz <mbroz@xxxxxxxxxx>
---
 drivers/acpi/processor_perflib.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Index: linux-2.6.26.y/drivers/acpi/processor_perflib.c
===================================================================
--- linux-2.6.26.y.orig/drivers/acpi/processor_perflib.c	2008-08-12 17:20:07.000000000 +0200
+++ linux-2.6.26.y/drivers/acpi/processor_perflib.c	2008-08-13 09:32:38.000000000 +0200
@@ -70,8 +70,8 @@ static DEFINE_MUTEX(performance_mutex);
  *  0 -> cpufreq low level drivers initialized -> consider _PPC values
  *  1 -> ignore _PPC totally -> forced by user through boot param
  */
-static unsigned int ignore_ppc = -1;
-module_param(ignore_ppc, uint, 0644);
+static int ignore_ppc = -1;
+module_param(ignore_ppc, int, 0644);
 MODULE_PARM_DESC(ignore_ppc, "If the frequency of your machine gets wrongly" \
 		 "limited by BIOS, this should help");
 



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/