Re: [RFC PATCH] x86 alternatives : fix LOCK_PREFIX race withpreemptible kernel and CPU hotplug

[Mathieu Desnoyers]

* H. Peter Anvin (hpa@xxxxxxxxx) wrote:
> Mathieu Desnoyers wrote:
>> Sure, here are the updated tables. Basically, they show no significant
>> difference between the NOP and the DS segment selector prefix
>> approaches.
>
> Actually, unless I have blown my T-test completely, they show with a 80% 
> and 74% confidence (respective for the two benchmarks) that the DS case is 
> slightly *better* (0.26% and 0.20% better, respective), which makes it a 
> no-brainer.  Doing around 10 runs of each is likely to confirm this 
> conclusion by pushing it into the 90+% interval.
>

Yes, I think you are right.

> Note that since the difference is so small, and so can also be due to some 
> kind of systematic error (lower ambient temperature during the DS run 
> making the disk drive slightly faster, what have you.)
>

I doubt it, because I made a "cache priming" run before the tests, which
made sure the data was all populated in memory. But yeah, having
different cpu clock calibration values/cpu clock frequency between
reboots could also cause that kind of difference.

Mathieu

> 	-hpa

-- 
Mathieu Desnoyers
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/