Re: [patch 7/8] x86: apic - unify sync_Arb_IDs

[Cyrill Gorcunov]

That happend sendmail/quilt sent mail by past :(. I'll fix and resend
tomorrow. thanks.

On 8/14/08, Maciej W. Rozycki <macro@xxxxxxxxxxxxxx> wrote:
> On Thu, 1 Jan 1970, Cyrill Gorcunov wrote:
>
>  Hmm, are you living in the past?
>
>> Signed-off-by: Cyrill Gorcunov <gorcunov@xxxxxxxxx>
>> ---
>>
>> diff --git a/arch/x86/kernel/apic_32.c b/arch/x86/kernel/apic_32.c
>> index 1d5f830..ec0f18f 100644
>> --- a/arch/x86/kernel/apic_32.c
>> +++ b/arch/x86/kernel/apic_32.c
>> @@ -919,8 +919,7 @@ void __init sync_Arb_IDs(void)
>>  	apic_wait_icr_idle();
>>
>>  	apic_printk(APIC_DEBUG, "Synchronizing Arb IDs.\n");
>> -	apic_write(APIC_ICR,
>> -		   APIC_DEST_ALLINC | APIC_INT_LEVELTRIG | APIC_DM_INIT);
>> +	apic_write(APIC_ICR, APIC_DEST_ALLINC | APIC_INT_LEVELTRIG |
>> APIC_DM_INIT);
>>  }
>>
>>  /*
> [etc...]
>
>  Well, I think this one is backwards...  There are exceptions, but the
> general rule is to with within the width of the terminal.
>
>   Maciej
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/