Re: [RFC PATCH] x86 alternatives : fix LOCK_PREFIX race with preemptiblekernel and CPU hotplug

From: Jeremy Fitzhardinge
Date: Thu Aug 14 2008 - 17:47:22 EST


Mathieu Desnoyers wrote:
I'm just worried about this comment from Harvey Harrison :

arch/x86/mm/fault.c : is_prefetch()

* Values 0x26,0x2E,0x36,0x3E are valid x86 prefixes.
* In X86_64 long mode, the CPU will signal invalid
* opcode if some of these prefixes are present so
* X86_64 will never get here anyway

I would say that comment is wrong. But we'd never put a lock prefix on a prefetch, so you won't be added a ds prefix either.

J
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/