Re: [patch 8/8] x86: apic - unify init_bsp_APIC

From: Cyrill Gorcunov
Date: Fri Aug 15 2008 - 02:41:21 EST


On Thu, Aug 14, 2008 at 11:44 PM, Maciej W. Rozycki
<macro@xxxxxxxxxxxxxx> wrote:
> On Thu, 1 Jan 1970, Cyrill Gorcunov wrote:
>
>> @@ -962,7 +962,8 @@ void __init init_bsp_APIC(void)
>> */
>> apic_write(APIC_LVT0, APIC_DM_EXTINT);
>> value = APIC_DM_NMI;
>> - if (!lapic_is_integrated()) /* 82489DX */
>> + /* discrete on 82489DX */
>> + if (!lapic_is_integrated())
>> value |= APIC_LVT_LEVEL_TRIGGER;
>> apic_write(APIC_LVT1, value);
>> }
>
> Please elaborate.
>
> Maciej
>

Hi Maciej,

don't really understand what do you mean. Do you mean it should
be a separate patch for this code snippet? Actually since we
always have lapic integrated on 64bit cpu gcc will eliminate
this check.

Cyrill
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/