Re: [PATCH] ftrace: use only 5 byte nops for x86

From: H. Peter Anvin
Date: Fri Aug 15 2008 - 18:38:23 EST


Ingo Molnar wrote:

TODO: Examine the cpuid to determine the nop to use.
Don't think that will help in general. qemu claims its a Pentium II.

ok. I've applied Steve's patch as it's a good bugfix. The extra paranoia about faulting on 0x90 seems excessive but doesnt hurt ;-)


I think what we need to do is to test the NOPL instruction and create a Linux-specific CPUID bit for it. I'll do that and submit to tip:x86/cpu.

-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/