Re: [PATCH] pci: change msi-x vector to 32bit

From: Eric W. Biederman
Date: Sat Aug 16 2008 - 04:23:57 EST


"H. Peter Anvin" <hpa@xxxxxxxxx> writes:

> The 28 bits aren't enough, are they: we need domain as well (and surely we can
> have more than 16 domains?)

The justification is questionable. The fact that the irq number
reported for msi-x vectors is only 16bits is a bug. Everywhere else
in the kernel an irq number is stored in a 32bit field.

We also have a few other bits of craziness in the msix interface.
The entry field in msix_entry is unnecessary.

In fact now that we have a linked list of irq entries we stop passing
the structure entirely.

Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/