Re: [git pull?] clocksource: ACPI pmtmr bugfixes [Was: Re: ACPIPM-Timer on K6-3 SiS5591: Houston...]

From: Andreas Mohr
Date: Mon Aug 18 2008 - 16:00:37 EST


Hi,

On Mon, Aug 18, 2008 at 09:35:17PM +0200, Dominik Brodowski wrote:
> Hi Andrew,
>
> On Mon, Aug 18, 2008 at 12:19:24PM -0700, Andrew Morton wrote:
> > : acpi_pm.c: check for monotonicity
> > :
> > : Expand the check for monotonicity by doing ten tests instead of one.
> >
> > Why?
>
> Indeed: http://lkml.org/lkml/2008/8/10/77 -- quote:
> "Result: catastrophic timer behaviour (a large backwards skip is possible),"
>
> The current check for monotonicity is way too weak. And at least on one
> system out there PMTMR is unuseable, but the current check fails.

Just want to say thank you for promptly following up on this issue!

I wanted to test your 2nd patch (improved init), but was unable to do so
(currently too busy due to large changes, plus distance to production system,
downtime NOT appreciated ;).

Andreas Mohr
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/