Re: [PATCH] Make gpiochip label const

[Andrew Morton]

On Tue, 19 Aug 2008 15:13:47 +0400
Dmitry <dbaryshkov@xxxxxxxxx> wrote:

> 2008/8/19 Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>:
> > On Sun, 17 Aug 2008 23:00:35 +0400 Dmitry Baryshkov <dbaryshkov@xxxxxxxxx> wrote:
> >
> >> On Tue, Aug 12, 2008 at 03:06:19PM -0700, David Brownell wrote:
> >> > > From dbaryshkov@xxxxxxxxx  Tue Aug 12 13:54:29 2008
> >> > > From: Dmitry Baryshkov <dbaryshkov@xxxxxxxxx>
> >> > > To: linux-kernel@xxxxxxxxxxxxxxx
> >> > > Cc: Dmitry Baryshkov <dbaryshkov@xxxxxxxxx>,
> >> > >   David Brownell <dbrownell@xxxxxxxxxxxxxxxxxxxxx>
> >> > > Subject: [PATCH] Make gpiochip label const
> >> > > Date: Wed, 13 Aug 2008 00:39:48 +0400
> >> > >
> >> > > Mark gpiochip label as a const char pointer.
> >> > >
> >> > > Signed-off-by: Dmitry Baryshkov <dbaryshkov@xxxxxxxxx>
> >> > > Cc: David Brownell <dbrownell@xxxxxxxxxxxxxxxxxxxxx>
> >> >
> >> > Acked-By: David Brownell <dbrownell@xxxxxxxxxxxxxxxxxxxxx>
> >> >
> >>
> >> Sorry to disturb, but will this make into 2.6.27-rc? Thanks.
> >>
> >
> > Ordinarily it would not.  Is there some reason why you think it should?
> >
> 
> It fixes lots of warnings (one per each instance of code filling the gpio chip)


That should have been in the changelog!

When fixing warnings or compilations errors, the compiler output should
also be in the changelog.

I don't recall seeing such warnings and I cannot make them happen with
drivers/gpio/gpiolib.c or with drivers/gpio/max732x.c or with
drivers/gpio/pca953x.c.  So we still don't know what this patch
does :(

> and is pretty much small to honour inclusion IMO

Well sure it's small.  But converting things to `const' carries a
fairly high risk of adding new warnings or breaking the build.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/