Re: [PATCH] CRED: Take cred_exec_mutex in compat_do_execve() andfix error handling in do_execve()

From: James Morris
Date: Tue Aug 19 2008 - 19:30:32 EST


On Tue, 19 Aug 2008, David Howells wrote:

> Take cred_exec_mutex in compat_do_execve(). This reflects what do_execve()
> does. The mutex protects credentials calculation against PTRACE_ATTACH needing
> to alter it mid-exec.
>
> Also fix the error handling in do_execve(). The mutex needs to be unlocked if
> an error occurs after it is taken, but before the install_exec_creds()
> released it.
>
> Signed-off-by: David Howells <dhowells@xxxxxxxxxx>

Applied to
git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/security-testing-2.6#next-creds

Hopefully this will be in the next linux-next tree for testing.

Alexander, please let us know if it fixes the problem you saw.


- James
--
James Morris
<jmorris@xxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/