Re: [PATCH 09/10] PPS: low level IRQ timestamps recording.

From: Ingo Molnar
Date: Wed Aug 20 2008 - 06:32:18 EST



* Rodolfo Giometti <giometti@xxxxxxxx> wrote:

> Add low level IRQ timestamps recording for x86 (32 and 64 bits)
> platforms and enable UART clients in order to use it.
>
> This improves PPS precision. :)
>
> Signed-off-by: Rodolfo Giometti <giometti@xxxxxxxx>
> ---
> arch/x86/kernel/irq_32.c | 18 ++++++++++++++++++
> arch/x86/kernel/irq_64.c | 22 ++++++++++++++++++++--
> drivers/pps/Kconfig | 12 ++++++++++++
> drivers/pps/clients/pps-ldisc.c | 18 ++++++++++++++++++
> include/linux/pps.h | 1 +
> 5 files changed, 69 insertions(+), 2 deletions(-)

hm, NACK on this line of approach. If then this instrumentation should
be done at the genirq level (kernel/irq/*.c). Also, the #ifdefs are ugly
- please hide them in include files.

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/