Re: [PATCH] ftrace: update recordmount.pl arch changes

From: Ingo Molnar
Date: Wed Aug 20 2008 - 06:47:38 EST



* Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:

> On Fri, 15 Aug 2008, Ingo Molnar wrote:
>
> >
> > * Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
> >
> > > Ingo,
> > >
> > > I'm trying to keep all the arch changes in recordmcount.pl in one
> > > place. I moved your code into that area, by adding the flags to the
> > > commands that were passed in.
> > >
> > > Does this change still work for you when compiling i386 on a x86_64
> > > box?
> >
> > actually, i thought of this as a quick hack to let -tip testing
> > continue. Dont we have all the proper information available in kbuild
> > and should just pass that to scripts/recordmcount.pl when called - like
> > we pass in things like OBJDUMP which might have cross-build overrides,
> > etc.
>
> Ingo,
>
> Could you use my updated patch. I know it is still just a work around, but
> your update broke my build. I use distcc which passes in "distcc" as gcc.
> My distcc is self built and is not the same as the distribution gcc.
>
> Ie, you have:
>
> if ($arch eq "x86_64") {
> $ld = "ld -m elf_x86_64";
> $objdump = "objdump -M x86-64";
> $objcopy = "objcopy -O elf64-x86-64";
> $cc = "gcc -m64";
> }
>
> Where the $cc = "gcc" is not compatible on my system. I end up with a bad
> build that causes ftrace to fail on bootup.

sure - applied to tip/tracing/ftrace.

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/