Re: [PATCH] fbdefio: add set_page_dirty handler to deferred IO FB

From: Ian Campbell
Date: Wed Aug 20 2008 - 15:41:20 EST


On Wed, 2008-08-20 at 12:30 -0700, Andrew Morton wrote:
> On Wed, 20 Aug 2008 19:57:53 +0100 Ian Campbell <ijc@xxxxxxxxxxxxxx>
> wrote:
> }
> > +#ifdef CONFIG_FB_DEFERRED_IO
> > + if (info->fbdefio)
> > + fb_deferred_io_open(info, inode, file);
> > +#endif
>
> eww, hacky, but drivers/video/fbmem.c already got hacky:
>
> #ifdef CONFIG_FB_DEFERRED_IO
> .fsync = fb_deferred_io_fsync,
> #endif
>
> so it's not an original sin.

That's what I figured.

> Does it work?

Yep.

Ian.
--
Ian Campbell

Nobody knows what goes between his cold toes and his warm ears.
-- Roy Harper

Attachment: signature.asc
Description: This is a digitally signed message part