Re: [RFC v2][PATCH 8/9] Remove some BUG_ON()s that need someproper error handling instead.

From: Dave Hansen
Date: Wed Aug 20 2008 - 16:30:12 EST


On Wed, 2008-08-20 at 12:26 -0700, Dave Hansen wrote:

> diff -puN checkpoint/checkpoint.c~0002-Remove-some-BUG_ON-s-that-need-some-proper-error-ha checkpoint/checkpoint.c
> --- oren-cr.git/checkpoint/checkpoint.c~0002-Remove-some-BUG_ON-s-that-need-some-proper-error-ha 2008-08-20 12:12:51.000000000 -0700
> +++ oren-cr.git-dave/checkpoint/checkpoint.c 2008-08-20 12:12:51.000000000 -0700
> @@ -125,7 +125,8 @@ static int cr_write_tail(struct cr_ctx *
> h.id = 0;
>
> hh->magic = CR_HEADER_MAGIC;
> - hh->cksum[0] = hh->cksum[1] = 1; /* TBD ... */
> + hh->cksum[0] = 1;
> + hh->cksum[1] = 1; /* TBD ... */
>
> ret = cr_write_obj(ctx, &h, hh);
> kfree(hh);

Whoops, that's a bad hunk that belongs in the next patch. Sorry.

-- Dave

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/