Re: [PATCH] ATA Kconfig cleanup: sort the driver list and modify some text

[Krzysztof Halasa]

Grant Coady <grant_lkml@xxxxxxxxxxx> writes:

> --- linux-2.6.27-rc3a/drivers/ata/Kconfig	2008-07-14 07:51:29.000000000 +1000
> +++ linux-2.6.27-rc3c/drivers/ata/Kconfig	2008-08-18 11:29:20.871422237 +1000
> @@ -3,7 +3,7 @@
>  #
>  
>  menuconfig ATA
> -	tristate "Serial ATA (prod) and Parallel ATA (experimental) drivers"
> +	tristate "Serial ATA and Parallel ATA (SATA/PATA) drivers"

I don't think so. Maybe
> +	tristate "Serial ATA (SATA) and Parallel ATA (PATA) drivers"

>  config ATA_SFF
>  	bool "ATA SFF support"
>  	default y
> @@ -93,123 +93,15 @@
>  
>  if ATA_SFF

How the user compiling the kernel knows what ATA_SFF stands for?
Why not "select ATA_SFF" instead (when any driver using this is
selected)?
-- 
Krzysztof Halasa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/