Re: patch "x86: MOVE PCI IO ECS code to x86/pci" breaks CPUhotplug

From: Jan Beulich
Date: Thu Aug 21 2008 - 09:18:39 EST


>>> Ingo Molnar <mingo@xxxxxxx> 21.08.08 15:02 >>>
>
>* Jan Beulich <jbeulich@xxxxxxxxxx> wrote:
>
>> Converting __cpuinit functions called out of init_amd() (and similar
>> others) to __init (and making them subject of xxx_initcall() handling
>> isn't valid, as they would no longer be called for hot plugged CPUs.
>>
>> Further, since it's likely that in virtualized environments the MSR
>> write would at best be ignored, I'd also recommend using the
>> fault-safe accessors here *and* check that the bit actually got set
>> before setting PCI_HAS_IO_ECS (one would obviously have to BUG() when
>> hot-plugged CPUs fail to set the bit when those available at boot
>> successfully did so).
>
>hm, which patch is this exactly, and in what tree? It's not upstream nor
>in -tip.

It is upstream:
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=3a27dd1ce5de08e21e0266ddf00e6f1f843bfe8b
(and I just verified it didn't change between -rc3 and -rc4).

Jan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/