Re: [PATCH] x86: silence section mismatch warning - uv_cpu_init

From: Ingo Molnar
Date: Fri Aug 22 2008 - 02:19:33 EST



* Marcin Slusarz <marcin.slusarz@xxxxxxxxx> wrote:

> From: Marcin Slusarz <marcin.slusarz@xxxxxxxxx>
> Subject: [PATCH v2] x86: fix section mismatch warning - uv_cpu_init
>
> WARNING: vmlinux.o(.cpuinit.text+0x3cc4): Section mismatch in reference from the function uv_cpu_init() to the function .init.text:uv_system_init()
> The function __cpuinit uv_cpu_init() references
> a function __init uv_system_init().
> If uv_system_init is only used by uv_cpu_init then
> annotate uv_system_init with a matching annotation.
>
> uv_system_init was ment to be called only once, so do it from codepath
> (native_smp_prepare_cpus) which is called once, right before activation
> of other cpus (smp_init).
>
> Note: old code relied on uv_node_to_blade being initialized to 0,
> but it'a not initialized from anywhere.

thanks - applied it to tip/x86/urgent. Jack, any objections?

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/