Re: [PATCH/RFC] Resolve 2 year old issue with different demandson EVIOCGRAB

From: Neil Brown
Date: Sun Aug 24 2008 - 19:49:18 EST


On Friday August 22, dmitry.torokhov@xxxxxxxxx wrote:
>
> Maybe openmoko could just patch mousedev to ignore touchscreens for
> now, until X is fixed?

Maybe. And in fact it already is!
As I delved further in to this issue, I find that not only is there a
patch in tslib to use EVIOCGRAB, but there is also a patch in the
kernel to exclude the "ABS_X + ABS_Y + BTN_TOUCH" case from mousedev,
making the EVIOCGRAB patch pointless.
And there might even be another patch in the kdrive Xserver to use
EVIOCGRAB in a different context (which might not actually be being
used, I'm not sure). A twisted maze of little passages, all
twisted. :-)

But I am firmly against carrying patches like this which cannot go
upstream. They can lead to subtle incompatibilities and can be hard
to get rid of. I much prefer a solution that can work for everyone,
and I currently think the BTN_TOUCH -> BTN_STYLUS change is that
solution. It remains to be seen which I can push into the openmoko
source tree :-)

Thanks,
NeilBrown
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/