Re: [RFC] Driver for Real Time Clock chip ST M41T65

From: Maciej W. Rozycki
Date: Tue Aug 26 2008 - 10:43:30 EST


On Tue, 26 Aug 2008, Steven A. Falco wrote:

> I'd also like to know if I should submit a new driver or mod the existing
> one. If I mod the existing one, should it be renamed, should I update the
> Kconfig, existing defconfigs, etc?

Keeping the code base common is good for maintenance. Therefore for a
minor differences like yours there is no doubt you better just add them to
the existing driver.

For larger variations -- it depends, i.e. it's better to keep the common
bits shared, unless the maintenance cost of such an approach exceeds that
of the other one. Frequently it just boils down to doing it right which
may not necessarily be easy. ;)

Maciej
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/