Re: [PATCH] afs: fsclient.c sparse endian annotations ofoperation_ID

[David Miller]

From: David Howells <dhowells@xxxxxxxxxx>
Date: Wed, 27 Aug 2008 12:12:24 +0100

> Harvey Harrison <harvey.harrison@xxxxxxxxx> wrote:
> 
> > +		if (call->operation_ID != __constant_htonl(FSFETCHDATA64)) {
> 
> Doesn't htonl() resolve to this for a constant argument?  Following through
> the definitions, it certainly looks like it ought to:

Yes it does.

The __constant_*() interfaces should only be uses for things that
must be evaluated at compile time (static data initializations,
switch statement case values etc.).
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/