Re: [PATCH RESEND] char_dev: add cdev->release() and convertcdev_alloc() to use it

[Greg KH]

On Thu, Aug 28, 2008 at 07:44:55PM +0200, Tejun Heo wrote:
> Greg KH wrote:
> > On Thu, Aug 28, 2008 at 06:56:48PM +0200, Tejun Heo wrote:
> >> Greg KH wrote:
> >>> Ick, I really don't want struct cdev to be used for lifecycle
> >>> management, as it is only for major:minor stuff.  Why do you want to
> >>> make this change?
> >> Well, as cdev can be referenced from userspace, ->release is required
> >> for most purposes.  The reason why devices have been getting by without
> >> it is because most chardevs are created on module load and destroyed on
> >> module unload and in the meantime cdev refcount virtually equals module
> >> refcnt, but I'm fairly sure we have cases where cdev can be destroyed
> >> for other reasons then module unloading and it's very likely those cases
> >> are buggy in the current code (backing structure gone bug cdev still
> >> hanging around).
> > 
> > Hm, I thought Al covered that when he created the cdev interface, I
> > would be a bit supprised if this was the case.
> 
> Hmmm.... I've never actually audited the code so... it could be that no
> chardev is created and destroyed that way, I guess.
> 
> >> As CUSE can create and destroy devices regardless of module reference
> >> count, it falls in the second category and needs cdev->release() to make
> >> sure the backing structure doesn't go away till cdev is released.
> > 
> > But CUSE should be it's own module, right?  And it would "own" the cdev,
> > so the module and cdev count should be fine and matching.  The userspace
> > code could go away but the CUSE code should handle that with a different
> > reference count.  This is the way that hardware drivers handle the
> > issue.
> 
> The problem is not the device to talk to CUSE (/dev/cuse as in
> /dev/fuse), for which module refcount and device refcount match fine.
> But the whole point of CUSE is allowing CUSE clients to create arbitrary
> character devices, so in addition to /dev/cuse which clients use to talk
> to CUSE, CUSE hosts character devices for its clients and they come and
> go dynamically and thus requires proper lifetime management.

That's fine, it's just like a USB device that uses a cdev, right?  Or a
PCI device, or any other type of device that can come and go independant
of the cdev or module lifespan.

So, you tie the cdev lifespan to the module lifespan with the
MODULE_OWNER in the file operations.  As the cuse.ko module will own the
cdev, it can handle that reference, and it can not be removed as long as
userspace has the cdev open, right?

It really isn't any different from any other type of removable device
(i.e. any type of device...)

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/