Re: autosuspend for SCSI devices

From: Pavel Machek
Date: Thu Aug 28 2008 - 16:28:22 EST


On Tue 2008-08-26 13:01:43, Oliver Neukum wrote:
> Am Dienstag 26 August 2008 11:43:55 schrieb Pavel Machek:
> > > firstly, it doesn't consider error handling before suspending.
> >
> > What problems do you see with error handling? This patch does not
> > touch the error handling, and I do not think it needs to touch it.
>
> You'd make scsi driver writers' life easier if you made sure no autosuspends
> happen while they recover from errors. After all, you have no idea which
> commands will get through while the bus is in disarray.

Well, they have to handle other commands while bus has problems,
anyway, right? So I'm not creating any _new_ problems for them.

Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/