Re: [PATCH] x86: split e820 reserved entries record to late v3

[Linus Torvalds]

On Thu, 28 Aug 2008, Yinghai Lu wrote:
>  /*
>   * Mark e820 reserved areas as busy for the resource manager.
>   */
> +struct resource __initdata *e820_res;

Btw, make this one "static" - I don't think anybody outside of this file 
should ever use it anyway.

And this:

> +		if (e820.map[i].type != E820_RESERVED || res->start < (1ULL<<20))
> +			insert_resource(&iomem_resource, res);

is probably worthy of a comment. 

And finally:

> +void __init e820_reserve_resources_late(void)
> +{
> +	int i;
> +	struct resource *res;
> +
> +	res = e820_res;
> +	for (i = 0; i < e820.nr_map; i++) {
> +		if (e820.map[i].type == E820_RESERVED && res->start >= (1ULL<<20))
> +			insert_resource(&iomem_resource, res);

instead of duplicating the conditional and always having to worry about it 
matching, how about just making it

		if (!res->parent)
			insert_resource(&iomem_resource, res);

which basically says that "if it's not already inserted, try to re-insert 
it now".

		Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/