Re: linux-next: Tree for September 1 (recordmcount.pl)

[Andrew Morton]

On Mon, 1 Sep 2008 11:25:49 -0700 Randy Dunlap <randy.dunlap@xxxxxxxxxx> wrote:

> On Mon, 1 Sep 2008 19:19:46 +1000 Stephen Rothwell wrote:
> 
> > Hi all,
> > 
> > Changes since next-20080829:
> 
> When using patch tarballs and applying that to kernel bases,
> scripts/recordmcount.pl fails because it is not executable.
> (Yes, I know, using the git would/should fix this.)
> 
> Is there any way to make (new) scripts executable when using
> tarballs?
> 
> I'll handle it on a case-by-case basis for now.
> 

I did this:

From: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>

  CHK     include/linux/version.h
  CHK     include/linux/utsrelease.h
  CC      scripts/mod/empty.o
/bin/sh: /usr/src/25/scripts/recordmcount.pl: Permission denied

We shouldn't assume that files have their `x' bits set.  There are various
ways in which file permissions get lost, including use of patch(1).

It might not be correct to assume that perl lives in $PATH?

Cc: Ingo Molnar <mingo@xxxxxxx>
Cc: Sam Ravnborg <sam@xxxxxxxxxxxx>
Cc: Steven Rostedt <rostedt@xxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---

 scripts/Makefile.build |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff -puN scripts/Makefile.build~kbuild-ftrace-dont-assume-that-scripts-recordmcountpl-is-executable scripts/Makefile.build
--- a/scripts/Makefile.build~kbuild-ftrace-dont-assume-that-scripts-recordmcountpl-is-executable
+++ a/scripts/Makefile.build
@@ -199,8 +199,9 @@ cmd_modversions =							\
 endif
 
 ifdef CONFIG_FTRACE_MCOUNT_RECORD
-cmd_record_mcount = $(srctree)/scripts/recordmcount.pl "$(ARCH)" \
-	"$(OBJDUMP)" "$(OBJCOPY)" "$(CC)" "$(LD)" "$(NM)" "$(RM)" "$(MV)" "$(@)";
+cmd_record_mcount = perl $(srctree)/scripts/recordmcount.pl \
+	"$(ARCH)" "$(OBJDUMP)" "$(OBJCOPY)" "$(CC)" "$(LD)" "$(NM)" "$(RM)" \
+	"$(MV)" "$(@)";
 endif
 
 define rule_cc_o_c
_


but I haven't been able to interest anyone in the patch yet.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/